refactor(core): allow passing optional check params to Authenticated … #6483
Conversation
🦋 Changeset detectedLatest commit: b16c179 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| check: async ({ params }) => { | ||
| // Simulate failed authentication based on params | ||
| return params?.allowAuth | ||
| ? { authenticated: true } | ||
| : { authenticated: false, redirectTo: "/login" }; | ||
| }, |
There was a problem hiding this comment.
Optionally, this can be simplified. Passing a mockCheck here and assert that mockCheck is called with given mockParams. But this also works because you are checking if redirect is called, so it's a matter of taste.
|
Oh, a minor thing I forgot, we could also update |
|
Oh. Okay @BatuhanW. sadly I have to run now... I'm not sure why the linting is throwing an error... I installed the biome extension, but can't get it to format the file for some reason.... is this something someone else can easily help with? |
|
Thanks @BatuhanW. Apologies I couldn't continue since too. Have my hands quite tied presently |
|
@reedwane no worries, we'll release it around December 5th. If we can't hear back from you until then, we can update documentation. |
alicanerdurmaz
changed the base branch from
master
to
releases/december-2024
|
edit: it seems it was an issue with github cli, not your actually. Now it's pushed. |
|
Thanks @BatuhanW The last couple of weeks have been quite the days. I'm just even seeing these notifications now. Thanks for completing the changes. |
…component
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
The
Authenticatedcomponent doesn't take extra params for the useIsAuthenticated hook to check the auth statusWhat is the new behavior?
The component now has
paramsin the props which is then passed to the authenticated hook call, which already allows forparams: anyfixes (#6309)
Notes for reviewers