Rails4 support patch #141
Rails4 support patch #141
Conversation
globalize gem add a validation for locale field in translation table we should be explicit expose locale more details see refinery#140
It's because the Mail gem depends on mime-types at ~> 1.16 and other gems have moved on to 2.0. Relates to mikel/mail#641
|
I'd prefer to get rid of our dependence on protected_attributes if possible and upgrade the library to strong_parameters instead. |
|
@parndt you mean do a patch on globalize gem ,let it support strong_parameters? |
|
No, globalize doesn't have to do anything, all the Refinery projects are at fault. |
|
@parndt Oops, if you gave me a hint, maybe i can do a patch on this topic. |
|
Basically Rails 4 shipped with strong_parameters which replaces attr_accessible and thus the protected_attributes gem completely. This requires you now filter parameters in the controller instead of the model. I believe there's a railscast on it. |
|
@parndt got it. feel this is big change on refinerycms codebase. give me some times ba. |
|
@parndt i found a potential question: In refinery/news/admin/items_controller.rb I am reading the crudify's readme, it only support rails 3. How to use it with strong parameters. |
|
We don't use an external version of crudify: that was extracted from refinerycms itself. Check https://github.com/refinery/refinerycms/blob/master/core/lib/refinery/crud.rb |
|
@xiaods are you still keen to add Rails 4 support? @parndt recently updated refinery/refinerycms repo to use strong parameters feature so you can check out what he did in refinery/refinerycms#2518. Let me know if you cannot continue this and I'll happily take over. |
|
@ugisozols I have no time on this patch currently, please ignore my progress. |
|
Alright. Closing this as I'm going to send a new PR. Thanks for putting time into this! :) |
through rspec guide, fix globalize gem usage issue.