Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable page caching when logged in to prevent caching the sitebar. #1609

Merged
merged 1 commit into from
Apr 22, 2012
Merged

Disable page caching when logged in to prevent caching the sitebar. #1609

merged 1 commit into from
Apr 22, 2012

Conversation

jokklan
Copy link
Contributor

@jokklan jokklan commented Apr 22, 2012

When cache_pages_full is enabled the page will be cached WITH the blue sitebar if you are logged in.

This commit should fix that.

@travisbot
Copy link

This pull request passes (merged 707128f into 755f94b).

@parndt
Copy link
Member

parndt commented Apr 22, 2012

Thank you; I think there's a method like refinery_user_signed_in? which might suit this better

@jokklan
Copy link
Contributor Author

jokklan commented Apr 22, 2012

There is yes, but in _site_bar.html.erb is the condition the following:

if refinery_user? && "#{controller_name}##{action_name}" != 'pages#preview'

so i thought i would make it the same?

parndt added a commit that referenced this pull request Apr 22, 2012
Disable page caching when logged in to prevent caching the sitebar.
@parndt parndt merged commit 29d4b03 into refinery:master Apr 22, 2012
@parndt
Copy link
Member

parndt commented Apr 22, 2012

Quite true, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants