-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cancel search link, fix p.2 from #1850 #1922
Conversation
@@ -50,8 +50,9 @@ en: | |||
current: Current File | |||
search: | |||
button_text: Search | |||
results_for: "Search results for '%{query}'" | |||
results_for: "Search results for ‘<em>%{query}</em>’" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This key should be results_for_html
now given it contains HTML.
Can you please put a before/after screenshot here so that we have the history of what this did? Thanks :) |
Looks good. |
Unfortunately I can't comment inline so I'm putting some code here. In the engine generator template (2nd line) there's code: refinery.admin_<%= plural_name %>_path The link won't work because engine routes are namespaced. You should use: refinery.<%= namespacing.underscore %>_admin_<%= plural_name %>_path |
@ugisozols please check if is look good for you now. |
@parndt ? :)