Update regex to match multiline config.action_mailer. #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Man oh man we need tests for this. Then we would know straight away if it solves the problem. |
ugisozols
added a commit
that referenced
this pull request
Nov 30, 2012
| Dummy::Application.configure do | ||
| if config.respond_to?(:action_mailer) | ||
| config.action_mailer.test = true | ||
| config.action_mailer.check = { |
There was a problem hiding this comment.
Not sure how to make generator indent this and subsequent lines.
|
@parndt ^ |
| @@ -9,6 +9,37 @@ module Refinery | |||
|
|
|||
| before do | |||
| prepare_destination | |||
|
|
|||
| dir = "#{destination_root}/config/environments" | |||
There was a problem hiding this comment.
I had to create env files myself because generator spec will only create Refinery's files.
|
@parndt is this good to merge? I'll squash commits if it is. |
|
I'm having a play. Feel free to squash the commits though and I'll update my copy :) I'll merge soon if I can't fix the indentation! |
Updated regex can now properly match config.action_mailer settings like:
config.action_mailer.raise_delivery_errors = false
and multiline:
config.action_mailer.raise_delivery_errors = false
config.action_mailer.smtp_settings = {
address: "test.com",
port: 123,
domain: "example.com"
}
|
Done. |
parndt
added a commit
that referenced
this pull request
Dec 5, 2012
ugisozols
added a commit
that referenced
this pull request
Dec 5, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1979
Updated regex can now properly match config.action_mailer settings like:
and multiline: