Set speakingurl-rails to 8.0.0, switch to poltergeist gem. #3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bricesanchez the sprockets error has disappeared, but now |
|
@bricesanchez this error is because |
|
I have to say this is quite a large dependency for such a small feature (used in one place, optionally) |
|
Yeah you're right, that's not good for us |
|
I think i've the fix https://travis-ci.org/refinery/refinerycms/builds/100263612 |
|
what about apps that aren't using sprockets? Must they now use it?
|
|
I'm a little confused on what is the best way to fix this issue. |
bricesanchez
added a commit
that referenced
this pull request
Jan 6, 2016
Set speakingurl-rails to 8.0.0, switch to poltergeist gem.
|
I've merged this PR because it's fixing the sprocket-rails 3.0 blocker issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #3080