Use font-awesome from font-awesome-sass gem #3108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricesanchez
changed the title
|
@ogerman Nice! @anitagraham What do you think of this PR? Is it ok with your icon set feature? |
|
Yes, it should be OK. I think there was a problem with the font-awesome-sass gem which meant I couldn't use it then. I guess it has been resolved. |
bricesanchez
added a commit
that referenced
this pull request
Feb 13, 2016
Use font-awesome from font-awesome-sass gem
|
Thanks @ogerman and @anitagraham ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That resolves conflict with font-awesome-sass gem (refinerycms has higher asset paths priority, and overrides it)
Also it makes refinerycms gem more lightweight and clean