XSS Bugfix #3097 - Sanitize SectionPresenter #3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricesanchez
force-pushed
the
bugfix/3097
branch
from
5c5f966
to
8f6a8ed
Compare
| @@ -7,6 +7,7 @@ class TitleSectionPresenter < SectionPresenter | |||
| private | |||
|
|
|||
| def wrap_content_in_tag(content) | |||
| content = sanitize(content) | |||
There was a problem hiding this comment.
We can inline this.
content_tag(:h1, sanitize(content), :id => id)
|
Looking good! |
bricesanchez
force-pushed
the
bugfix/3097
branch
from
8f6a8ed
to
8d27789
Compare
|
Done :) |
parndt
added a commit
that referenced
this pull request
Mar 5, 2016
stefanspicer
added a commit
to stefanspicer/refinerycms
that referenced
this pull request
Mar 28, 2016
This change was lost in a rebase (this html changed files) It is from: - commit: 5645295 - PR: refinery#3117 - Bugfix: refinery#3097
bricesanchez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's ready to be reviewed and merged.
It fix #3097