Split and tidy up stylesheets #3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricesanchez
force-pushed
the
feature/tidy-up-stylesheets
branch
from
d6aff32
to
df1d0ef
Compare
|
|
||
| // $icon_preview_colour: #7f00ff; // violet | ||
| // $icon_edit_colour: #007fff; // azure | ||
| // $icon_add_colour: #7fff00; // chartreuse |
There was a problem hiding this comment.
did you mean to leave in the commented out rules?
There was a problem hiding this comment.
I could do a complete refactor of the current CSS for this PR but i think it's better to do this in an second PR in order to keep easy the review.
There was a problem hiding this comment.
Oh, I see, these were already there.
* create components folder * create global folder * create mixins folder * create plugins folder * create sections folder * Split and tidy up stylesheets
bricesanchez
force-pushed
the
feature/tidy-up-stylesheets
branch
from
df1d0ef
to
9b99393
Compare
|
Looks good to me |
|
++ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first of a PR series in order to improve the modularity of the backend stylesheets.
This PR made no UI changes.
The goals are :
Mergers, please test this PR before merging it.