Fixed admin menu items duplicating after extensions code changing #3234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, I really like this code 😉 Once this passes CI I'll merge it. |
|
Nice, this method looks good to me also, because I think forcing the reloading or all the Refinery::Plugins code after every Refinery::Plugin change is much less effective than just to filter an array one time. |
|
Absolutely agree 😄 |
parndt
pushed a commit
that referenced
this pull request
Jul 26, 2016
|
I've cherry picked this across to master too 23781a8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #3087 (comment) issue