Fix permitted params allowing new images to be uploaded #3278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing tests do not have anything to do with my PR. I had the same issue when trying to build a test-case. It is because the quiet_assets gem is trying to include Rails 5. It probably needs some version constraints (I 'solved' it by removing the gem :P ) |
|
Does it still work to upload multiple images? |
|
I did not know that it is possible to upload multiple images..! I'll check it out and report back |
|
It still works when adding new images (they are all added as separate images), when modifying an image I do not seem to be able to select multiple (but I assume that is logical?) |
|
That's right, you can only upload multiple when you're adding new images |
|
Thanks @veger! It takes time but it's finally merged :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes uploading a new image for existing images. I would have expected that with the original/wrong permitted params uploading the initial image would have failed (but it obviously does not).
I have been fiddling over 2 hours to get a test case for this PR, but my knowledge of rspec/features, capybara, and the combination of both is seriously lacking... So no test-case this time... :(
Manual test show that adding a new image still works, and uploading a new one does as well (I get an error when I upload an image with an different name, see #3279)