Extract permitted params lists #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasgarciaisaia
force-pushed
the
feature/extract-permitted-params-list
branch
2 times, most recently
from
3af8389 to
52292d8
Compare
| end | ||
|
|
||
| def permitted_new_page_part_params |
There was a problem hiding this comment.
This method should be private like all other permitted_* methods in Refinery
matiasgarciaisaia
added a commit
to manastech/refinerycms
that referenced
this pull request
Jan 17, 2018
|
👌 Fixed that! I can squash/rebase the commits before merging - made a different commit to help with reviewing. |
|
@matiasgarciaisaia it will be perfect if you could do this, it's better for tracking changes in the git log! Thank you very much! |
So they can be easily extended by (...wait for it...) _extensions_
matiasgarciaisaia
force-pushed
the
feature/extract-permitted-params-list
branch
from
9da0241 to
edc4eb2
Compare
|
There! ☝️ 🎉 |
|
Thank you @matiasgarciaisaia ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So they can be easily extended by (...wait for it...) extensions.