[custom_slug] Makes it possible to have non-unique custom slugs #3378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @xnagpa! Thanks for you Pull Request! I like this feature but could you update/fix the specs? Thanks :) |
|
Hi Brice!
I'm just puzzled with custom_slug fields disappearance. Did you remove it?
|
|
Nope, the feature is still present : https://github.com/refinery/refinerycms/search?l=Ruby&q=custom_slug&type= |
|
Understood!
|
added 2 commits
July 25, 2018 14:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that custom_slug in pages.rb is unique no matter what.
It would be better to have unique custom_slug in scope of one parent page.
So we can have urls like /first_company/about, /second_company/about.
Custom_slug is valid if pages on the same depth level doesn't have the same custom_slug.