Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to GitHub Actions for CI #3444

Merged
merged 84 commits into from
Sep 2, 2020
Merged

Migrate to GitHub Actions for CI #3444

merged 84 commits into from
Sep 2, 2020

Conversation

parndt
Copy link
Member

@parndt parndt commented Oct 1, 2019 •
edited
Loading

I decided to move our continuous integration to GitHub Actions.

parndt
parndt commented Oct 1, 2019
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
parndt
parndt commented Oct 1, 2019
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
parndt
parndt commented Oct 1, 2019
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
@parndt
gimme a tab
a3a412b 
no time for that, the computer's starting!
parndt
parndt commented Oct 2, 2019
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
parndt
parndt commented Oct 2, 2019
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
parndt
parndt commented Oct 2, 2019
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
parndt
parndt commented Oct 2, 2019
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
parndt
parndt commented Oct 2, 2019
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
parndt
parndt commented Oct 2, 2019
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
parndt
parndt commented Oct 2, 2019
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
parndt
parndt commented Oct 2, 2019
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
@parndt parndt marked this pull request as ready for review August 31, 2020 00:54
@parndt
Copy link
Member Author

parndt commented Aug 31, 2020

Just need to support more ruby versions now

@parndt parndt requested a review from bricesanchez August 31, 2020 02:07
@parndt
Copy link
Member Author

parndt commented Aug 31, 2020

@bricesanchez it works! And it didn't even take me a year! 😂

bricesanchez
bricesanchez approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@bricesanchez bricesanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !

@parndt parndt merged commit 1b73e0b into master Sep 2, 2020
@parndt
Copy link
Member Author

parndt commented Sep 2, 2020

Thanks @bricesanchez and @simi !

@parndt parndt deleted the github-actions-ci branch September 2, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bricesanchez bricesanchez bricesanchez approved these changes

@simi simi simi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parndt @simi @bricesanchez