Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nba app radix #199

Merged
merged 9 commits into from
Feb 14, 2024
Merged

Nba app radix #199

merged 9 commits into from
Feb 14, 2024

Conversation

tgberkeley
Copy link
Collaborator

No description provided.

@martinxu9 martinxu9 self-requested a review February 13, 2024 22:47
Copy link
Contributor

@martinxu9 martinxu9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also let's keep the name as nba instead of nba_radix

@@ -1,6 +1,6 @@
name: app-harness
env:
REFLEX_VERSION: "==0.3.8"
REFLEX_VERSION: "==0.3.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make another PR for it, we can keep only the app changes in this PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the old nba app?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's been moved into a chakra directory

@@ -0,0 +1,3 @@
reflex>=0.3.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.4.0?

@tgberkeley
Copy link
Collaborator Author

This PR should be all good to go now

@martinxu9 martinxu9 merged commit 544fd2d into reflex-0.4.0 Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants