-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nba app radix #199
Nba app radix #199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also let's keep the name as nba instead of nba_radix
.github/workflows/app_harness.yml
Outdated
@@ -1,6 +1,6 @@ | |||
name: app-harness | |||
env: | |||
REFLEX_VERSION: "==0.3.8" | |||
REFLEX_VERSION: "==0.3.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make another PR for it, we can keep only the app changes in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the old nba app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's been moved into a chakra directory
nba_radix/requirements.txt
Outdated
@@ -0,0 +1,3 @@ | |||
reflex>=0.3.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.4.0?
This PR should be all good to go now |
No description provided.