Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataList component to the documentation #863

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

elviskahoro
Copy link
Contributor

This pull request adds documentation for the DataList component in the Reflex library. The new markdown file introduces the DataList component, explaining its purpose for displaying key-value pairs and metadata. It provides a basic example of how to initialize and use the DataList component with rx.data_list.root() and rx.data_list.item. The documentation also mentions potential future improvements to simplify the initialization process for DataList.

Copy link

linear bot commented Aug 23, 2024

Copy link
Contributor Author

elviskahoro commented Aug 23, 2024

@elviskahoro elviskahoro requested a review from Lendemor August 23, 2024 19:52
@elviskahoro elviskahoro force-pushed the elvis/ref-3558-document-radix-component-skeleton branch 2 times, most recently from 9c30f5e to 9495749 Compare August 23, 2024 20:07
@elviskahoro elviskahoro force-pushed the elvis/ref-3561-document-radix-component-datalist branch from 67e42be to e890b98 Compare August 23, 2024 20:07
Copy link
Contributor Author

elviskahoro commented Aug 23, 2024

Merge activity

  • Aug 23, 4:25 PM EDT: @elviskahoro started a stack merge that includes this pull request via Graphite.
  • Aug 23, 4:37 PM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 23, 4:37 PM EDT: Graphite couldn't merge this PR because it failed optional checks and "ignore optional checks" was not selected.
  • Aug 23, 5:03 PM EDT: @elviskahoro started a stack merge that includes this pull request via Graphite.
  • Aug 23, 5:03 PM EDT: @elviskahoro merged this pull request with Graphite.

@elviskahoro elviskahoro changed the base branch from elvis/ref-3558-document-radix-component-skeleton to graphite-base/863 August 23, 2024 20:26
@elviskahoro elviskahoro changed the base branch from graphite-base/863 to main August 23, 2024 20:35
@elviskahoro elviskahoro force-pushed the elvis/ref-3561-document-radix-component-datalist branch from e890b98 to 418c00a Compare August 23, 2024 20:36
@elviskahoro elviskahoro merged commit 5b1a52a into main Aug 23, 2024
2 of 5 checks passed
@masenf
Copy link
Collaborator

masenf commented Aug 23, 2024

unbreaking the build #866

do we have a follow up for 3561 to add generated API reference for the item, label and value components which are currently missing comments in reflex itself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants