Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new var documentation #906

Closed
wants to merge 10 commits into from
Closed

add new var documentation #906

wants to merge 10 commits into from

Conversation

adhami3310
Copy link
Member

@elviskahoro
Copy link
Contributor

@linear #ENG-1983

@elviskahoro
Copy link
Contributor

ENG-1983

@elviskahoro
Copy link
Contributor

Fixes ENG-1983

@elviskahoro
Copy link
Contributor

@adhami3310 I'm better on linear than in github cause my notifications are more streamlined.

@Alek99
Copy link
Member

Alek99 commented Sep 17, 2024

What's the status on this @elviskahoro are you leaving feedback on comments on the PR or addressing on linear? I think its better to do everything in the PR that's way it stays in a single place.

@elviskahoro
Copy link
Contributor

What's the status on this @elviskahoro are you leaving feedback on comments on the PR or addressing on linear? I think its better to do everything in the PR that's way it stays in a single place.

@adhami3310 said the var system has already changed again and so we're gonna revisit these once they're finalized + after fixing flexdown
@picklelo has some context on flexdown I think??

@elviskahoro elviskahoro self-requested a review September 23, 2024 23:22
@elviskahoro
Copy link
Contributor

Closing in favor of:
#937

@Kastier1 Kastier1 deleted the var-docs branch January 25, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants