Skip to content

Commit

Permalink
remove actor
Browse files Browse the repository at this point in the history
  • Loading branch information
Alek Petuskey authored and Alek Petuskey committed Jul 16, 2024
1 parent 2d06d32 commit 1859dc1
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ jobs:
--python-version "${{ matrix.python-version }}" --commit-sha "${{ github.sha }}"
--benchmark-json "${{ env.OUTPUT_FILE }}"
--db-url "${{ env.DATABASE_URL }}" --branch-name "${{ github.head_ref || github.ref_name }}"
--event-type "${{ github.event_name }}" --actor "${{ github.actor }}" --pr-id "${{ github.event.pull_request.id }}"
--event-type "${{ github.event_name }}" --pr-id "${{ github.event.pull_request.id }}"

reflex-build-size:
if: github.event.pull_request.merged == true
Expand Down
2 changes: 0 additions & 2 deletions scripts/benchmarks/benchmark_reflex_size.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ def insert_benchmarking_data(
branch_name: str,
pr_id: str,
path: str,
actor: str,
):
"""Insert the benchmarking data into PostHog.
Expand Down Expand Up @@ -125,7 +124,6 @@ def insert_benchmarking_data(
"api_key": "phc_JoMo0fOyi0GQAooY3UyO9k0hebGkMyFJrrCw1Gt5SGb",
"event": "size_benchmark",
"properties": {
"distinct_id": actor,
"os": os_type_version,
"python_version": python_version,
"commit_sha": commit_sha,
Expand Down
8 changes: 0 additions & 8 deletions scripts/benchmarks/simple_app_benchmark_upload.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ def insert_benchmarking_data(
pr_title: str,
branch_name: str,
event_type: str,
actor: str,
pr_id: str,
):
"""Insert the benchmarking data into the database.
Expand All @@ -85,7 +84,6 @@ def insert_benchmarking_data(
"api_key": "phc_JoMo0fOyi0GQAooY3UyO9k0hebGkMyFJrrCw1Gt5SGb",
"event": "simple_app_benchmark",
"properties": {
"distinct_id": actor,
"os": os_type_version,
"python_version": python_version,
"commit_sha": commit_sha,
Expand Down Expand Up @@ -143,11 +141,6 @@ def main():
help="The github event type",
required=True,
)
parser.add_argument(
"--actor",
help="Username of the user that triggered the run.",
required=True,
)
parser.add_argument(
"--pr-id",
help="ID of the PR.",
Expand All @@ -170,7 +163,6 @@ def main():
pr_title=pr_title,
branch_name=args.branch_name,
event_type=args.event_type,
actor=args.actor,
pr_id=args.pr_id,
)

Expand Down

0 comments on commit 1859dc1

Please sign in to comment.