Skip to content

Commit

Permalink
test dynamic route flakiness (can't reproduce locally) (#4496)
Browse files Browse the repository at this point in the history
* test dynamic route flakiness (can't reproduce locally)

* fix typo
  • Loading branch information
benedikt-bartscher authored Dec 6, 2024
1 parent 3f4dca2 commit 3a225c2
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions tests/integration/test_dynamic_routes.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

from __future__ import annotations

import time
from typing import Callable, Coroutine, Generator, Type
from urllib.parse import urlsplit

Expand Down Expand Up @@ -177,6 +178,8 @@ def driver(dynamic_route: AppHarness) -> Generator[WebDriver, None, None]:
"""
assert dynamic_route.app_instance is not None, "app is not running"
driver = dynamic_route.frontend()
# TODO: drop after flakiness is resolved
driver.implicitly_wait(30)
try:
yield driver
finally:
Expand Down Expand Up @@ -391,6 +394,9 @@ async def test_render_dynamic_arg(
with poll_for_navigation(driver):
driver.get(f"{dynamic_route.frontend_url}/arg/0")

# TODO: drop after flakiness is resolved
time.sleep(3)

def assert_content(expected: str, expect_not: str):
ids = [
"state-arg_str",
Expand Down

0 comments on commit 3a225c2

Please sign in to comment.