Skip to content

Commit

Permalink
add warning when using css props on recharts (#3651)
Browse files Browse the repository at this point in the history
  • Loading branch information
Lendemor authored Jul 11, 2024
1 parent 1cfc811 commit 4f9a75b
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 1 deletion.
17 changes: 16 additions & 1 deletion reflex/components/recharts/recharts.py
Original file line number Diff line number Diff line change
@@ -1,15 +1,30 @@
"""A component that wraps a recharts lib."""

from typing import Literal
from typing import Dict, Literal

from reflex.components.component import Component, MemoizationLeaf, NoSSRComponent
from reflex.utils import console


class Recharts(Component):
"""A component that wraps a recharts lib."""

library = "recharts@2.12.7"

def render(self) -> Dict:
"""Render the tag.
Returns:
The rendered tag.
"""
tag = super().render()
if any(p.startswith("css") for p in tag["props"]):
console.warn(
f"CSS props do not work for {self.__class__.__name__}. Consult docs to style it with its own prop."
)
tag["props"] = [p for p in tag["props"] if not p.startswith("css")]
return tag


class RechartsCharts(NoSSRComponent, MemoizationLeaf):
"""A component that wraps a recharts lib."""
Expand Down
1 change: 1 addition & 0 deletions reflex/components/recharts/recharts.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ from reflex.style import Style
from reflex.vars import BaseVar, Var

class Recharts(Component):
def render(self) -> Dict: ...
@overload
@classmethod
def create( # type: ignore
Expand Down

0 comments on commit 4f9a75b

Please sign in to comment.