Skip to content

Commit

Permalink
use is true for bool var (#3973)
Browse files Browse the repository at this point in the history
  • Loading branch information
adhami3310 authored and masenf committed Sep 24, 2024
1 parent dfad519 commit 73f3454
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 8 deletions.
8 changes: 0 additions & 8 deletions reflex/vars/sequence.py
Original file line number Diff line number Diff line change
Expand Up @@ -194,14 +194,6 @@ def strip(self) -> StringVar:
"""
return string_strip_operation(self)

def bool(self):
"""Boolean conversion.
Returns:
The boolean value of the string.
"""
return self.length() != 0

def reversed(self) -> StringVar:
"""Reverse the string.
Expand Down
15 changes: 15 additions & 0 deletions tests/test_var.py
Original file line number Diff line number Diff line change
Expand Up @@ -962,6 +962,21 @@ def test_all_number_operations():
)


@pytest.mark.parametrize(
("var", "expected"),
[
(Var.create(False), "false"),
(Var.create(True), "true"),
(Var.create("false"), 'isTrue("false")'),
(Var.create([1, 2, 3]), "isTrue([1, 2, 3])"),
(Var.create({"a": 1, "b": 2}), 'isTrue(({ ["a"] : 1, ["b"] : 2 }))'),
(Var("mysterious_var"), "isTrue(mysterious_var)"),
],
)
def test_boolify_operations(var, expected):
assert str(var.bool()) == expected


def test_index_operation():
array_var = LiteralArrayVar.create([1, 2, 3, 4, 5])
assert str(array_var[0]) == "[1, 2, 3, 4, 5].at(0)"
Expand Down

0 comments on commit 73f3454

Please sign in to comment.