Skip to content

Commit

Permalink
fix unionize recursion (#3948)
Browse files Browse the repository at this point in the history
* fix unionize recursion

* merging

---------

Co-authored-by: Khaleel Al-Adhami <khaleel.aladhami@gmail.com>
  • Loading branch information
2 people authored and masenf committed Sep 20, 2024
1 parent 6ae6698 commit ddb189a
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 4 deletions.
11 changes: 7 additions & 4 deletions reflex/vars/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -1199,10 +1199,13 @@ def unionize(*args: Type) -> Type:
"""
if not args:
return Any
first, *rest = args
if not rest:
return first
return Union[first, unionize(*rest)]
if len(args) == 1:
return args[0]
# We are bisecting the args list here to avoid hitting the recursion limit
# In Python versions >= 3.11, we can simply do `return Union[*args]`
midpoint = len(args) // 2
first_half, second_half = args[:midpoint], args[midpoint:]
return Union[unionize(*first_half), unionize(*second_half)]


def figure_out_type(value: Any) -> types.GenericType:
Expand Down
21 changes: 21 additions & 0 deletions tests/vars/test_base.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
from typing import Dict, List, Union

import pytest

from reflex.vars.base import figure_out_type


@pytest.mark.parametrize(
("value", "expected"),
[
(1, int),
(1.0, float),
("a", str),
([1, 2, 3], List[int]),
([1, 2.0, "a"], List[Union[int, float, str]]),
({"a": 1, "b": 2}, Dict[str, int]),
({"a": 1, 2: "b"}, Dict[Union[int, str], Union[str, int]]),
],
)
def test_figure_out_type(value, expected):
assert figure_out_type(value) == expected

0 comments on commit ddb189a

Please sign in to comment.