Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LiteralEventChainVar doesn't include appropriate hooks #4608

Open
masenf opened this issue Jan 8, 2025 · 1 comment
Open

LiteralEventChainVar doesn't include appropriate hooks #4608

masenf opened this issue Jan 8, 2025 · 1 comment

Comments

@masenf
Copy link
Collaborator

masenf commented Jan 8, 2025

Describe the bug
A LiteralEventChainVar should include var_data that adds the hook for addEvents (or whatever the invocation is).

EventChain.create should accept arbitrary kwargs to pass to the EventChain constructor.

rx.Var.create throws away passed _var_data for non-str values

Specifics (please complete the following information):

  • Python Version: 3.12.8
  • Reflex Version: 0.6.8a1
  • OS: macOS
@linear Linear
Copy link

linear bot commented Jan 8, 2025

ENG-4335 LiteralEventChainVar doesn't include appropriate hooks

masenf added a commit that referenced this issue Jan 8, 2025
@masenf
EventChain.create accepts arbitrary kwargs
28f7f38 
Pass _var_data when creating LiteralVar

Partial fixes for #4608
@masenf masenf mentioned this issue Jan 8, 2025
Merged
masenf added a commit that referenced this issue Jan 10, 2025
@masenf
EventChain.create accepts arbitrary kwargs (#4609)
fe9c020 
Pass _var_data when creating LiteralVar

Partial fixes for #4608
masenf added a commit that referenced this issue Jan 10, 2025
@masenf
EventChain.create accepts arbitrary kwargs (#4609)
727c87c 
Pass _var_data when creating LiteralVar

Partial fixes for #4608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@masenf