Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add Editor component #1060

Closed
wants to merge 2 commits into from
Closed

WIP: Add Editor component #1060

wants to merge 2 commits into from

Conversation

iron3oxide
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Almost done, the component renders. Two tasks remain:

  1. Finishing up get_controlled_triggers. I don't yet understand how EventHandlers receive their parameters, someone who does could be of help because it is the only way to retrieve the editors contents.
  2. Figuring out why passing a custom button_list in EditorOptions to set_options doesn't seem to affect the toolbar buttons at all. The object seems to work, passing rtl for instance switches the editor to RTL mode.

Closes #995

@masenf masenf added the needs rebase PR must be rebased before it can be merged label Jul 18, 2023
@masenf
Copy link
Collaborator

masenf commented Jul 18, 2023

Please rebase against latest main after the reflex rebranding.

@iron3oxide
Copy link
Contributor Author

Unless someone wants to finish what I started here, I'd rather just close the PR as I don't plan on implementing this anymore.

@masenf masenf mentioned this pull request Sep 21, 2023
@masenf
Copy link
Collaborator

masenf commented Sep 21, 2023

supersede by #1851

@masenf masenf closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase PR must be rebased before it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add WYSIWYG text editor component
2 participants