ConnectionModal and ConnectionBanner cleanup #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masenf
changed the title
picklelo
reviewed
Jul 31, 2023
| @@ -15,6 +15,7 @@ class State(rx.State): | |||
|
|
|||
| def index() -> rx.Component: | |||
| return rx.fragment( | |||
| rx.connection_modal(), # displays error when backend cannot connect | |||
There was a problem hiding this comment.
Should we enable this in all apps by default? And have them specify if they want this in the config?
allow connection banner code to access the error message and other details about the websocket error to provide more context to the user.
* expose `connection_error` var for downstream use * expose `has_connection_error` var for downstream use * expose `default_connection_error` as list[str | Var] for downstream use with other components or styles without duplicating the error message * include API_URL in the error message so users can easily see what the frontend was trying to connect to Create `rx.connection_modal` which takes over the page and definitely does NOT give any illusion as to the page interactivity status.
show off the connection status modal dialog in the default template to help users determine when their backend is disconnected. fix #1364
masenf
force-pushed
the
masenf/connection-banner-cleanup
branch
from
7f562b2 to
7ab8bd6
Compare
|
Rebased on the new refactored event loop. |
it doesn't _really_ matter in this context, but we might as well be consistent with how the var is defined in `useEventLoop`
by default, this is the ConnectionModal, but it could be any component, or None to disable it entirely
allow overlay_component to be a callable handle circular import of reflex.config to get the api_url
picklelo
approved these changes
Aug 29, 2023
| "Cannot connect to server: ", | ||
| connection_error, | ||
| ". Check if server is reachable at ", | ||
| get_config().api_url or "<API_URL not set>", |
There was a problem hiding this comment.
Nit: should we put the url inside an rx.link for easier access?
There was a problem hiding this comment.
Yeah and maybe link it to /ping?
| @@ -269,6 +275,31 @@ def add_middleware(self, middleware: Middleware, index: Optional[int] = None): | |||
| else: | |||
| self.middleware.insert(index, middleware) | |||
|
|
|||
| @staticmethod | |||
| def _generate_component(component: Component | ComponentCallable) -> Component: | |||
There was a problem hiding this comment.
We can move this out of this class also, to a utils file
There was a problem hiding this comment.
I'll do it for the client side routing PR, since I also need to expand the 404 page over there before I pass it to wait_for_redir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
state: save connectError instead of notConnected boolean
Allow connection banner code to access the error message and other details about the websocket error to provide more context to the user.
Add ConnectionModal for displaying connection errors
connection_errorvar for downstream usehas_connection_errorvar for downstream usedefault_connection_erroras list[str | Var] for downstream use withother components or styles without duplicating the error message
was trying to connect to
Create
rx.connection_modalwhich takes over the page and definitely does NOTgive any illusion as to the page interactivity status.
default template: add rx.connection_modal()
show off the connection status modal dialog in the default template to help users determine when their backend is disconnected.
fix #1364