Add Node Version Error Handling #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alek99
changed the title
picklelo
reviewed
Dec 22, 2022
picklelo
reviewed
Dec 22, 2022
picklelo
reviewed
Dec 22, 2022
pynecone/utils.py
Outdated
| ) | ||
| # The output will be in the form "vX.Y.Z", so we can split it on the "v" character and take the second part | ||
| version = result.stdout.decode().strip().split("v")[1] | ||
| # Split the version string on the "." character and convert each part to an integer |
There was a problem hiding this comment.
Right here I think you can just
return version.split(".") > min_version.split(".")
There was a problem hiding this comment.
Yeah good catch, gpt complicated it
picklelo
reviewed
Dec 22, 2022
| ["node", "-v"], stdout=subprocess.PIPE, stderr=subprocess.PIPE | ||
| ) | ||
| # The output will be in the form "vX.Y.Z", so we can split it on the "v" character and take the second part | ||
| version = result.stdout.decode().strip().split("v")[1] |
There was a problem hiding this comment.
I don't think we need this line either if we don't cast to int
There was a problem hiding this comment.
I actually need this line because the output has v
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.