model: only pass "check_same_thread" arg for sqlite database #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picklelo
approved these changes
Aug 22, 2023
picklelo
reviewed
Aug 22, 2023
| connect_args={"check_same_thread": False}, | ||
| ) | ||
| # Needed for the admin dash on sqlite. | ||
| connect_args = {"check_same_thread": False} if url.startswith("sqlite") else {} |
There was a problem hiding this comment.
Just saw the original line was:
connect_args={"check_same_thread": False} if conf.admin_dash else {}But we don't have the admin_dash in config anymore. Should we still check that arg? I'm not sure what this param does actually.
There was a problem hiding this comment.
in sqlite, you get an exception if different threads use the same connection; and admin_dash runs on a different thread, so this param ignores that check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1661