Avoid compile step when running production backend #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When executing `reflex run --env prod`, set `REFLEX_SKIP_COMPILE=yes` and then during `App.compile`, exit early if this env var is set. This avoids running the compile needlessly, since the prod backend does NOT use the compiled output for anything. In DEV mode, we must keep the compile step, because uvicorn re-importing the app module and triggering the compile on the backend is what triggers the NextJS frontend to rebuild.
the db commands never need to compile the app
11 tasks
picklelo
reviewed
Aug 25, 2023
picklelo
approved these changes
Aug 25, 2023
| uvicorn.run( | ||
| app=f"{app_name}:{constants.APP_VAR}.{constants.API_VAR}", | ||
| app=f"{app_module}.{constants.API_VAR}", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing
reflex run --env prod, setREFLEX_SKIP_COMPILE=yesand then duringApp.compile, exit early if this env var is set. This avoids running the compile needlessly, since the prod backend does NOT use the compiled output for anything.In DEV mode, we must keep the compile step, because uvicorn re-importing the app module and triggering the compile on the backend is what triggers the NextJS frontend to rebuild.
REF-160