Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:issue-1667;added if condition check to not echo DB_URL #1681

Merged
merged 2 commits into from
Aug 25, 2023
Merged

fix:issue-1667;added if condition check to not echo DB_URL #1681

merged 2 commits into from
Aug 25, 2023

Conversation

shashank40
Copy link
Contributor

@shashank40 shashank40 commented Aug 25, 2023 •
edited
Loading

All Submissions:

  • [Yes ] Have you followed the guidelines stated in CONTRIBUTING.md file?
  • [Yes ] Have you checked to ensure there aren't any other open Pull Requests for the desired change?

Type of change

Please delete options that are not relevant.

  • [Yes ] Bug fix (non-breaking change which fixes an issue

New Feature Submission:

  • [Yes] Does your submission pass the tests?
  • [Yes] Have you linted your code locally prior to submission?

Changes To Core Features:

  • [Yes] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [Yes] Have you successfully ran tests with your changes locally?

@shashank40
Copy link
Contributor Author

closes #1667

@shashank40 shashank40 mentioned this pull request Aug 25, 2023
Closed
@shashank40
Copy link
Contributor Author

@picklelo @masenf

picklelo
picklelo approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding!

@picklelo picklelo merged commit b02afc3 into reflex-dev:main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picklelo picklelo picklelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shashank40 @picklelo