Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generic alias checks #172

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Fix generic alias checks #172

merged 1 commit into from
Dec 23, 2022

Conversation

picklelo
Copy link
Contributor

  • Use is_generic_alias check to handle all Python versions

@picklelo picklelo linked an issue Dec 22, 2022 that may be closed by this pull request
pc run fails with Python 3.11 (but works with previous versions of python) #162
Closed
@Alek99 Alek99 self-requested a review December 22, 2022 23:59
Alek99
Alek99 approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@Alek99 Alek99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@picklelo picklelo merged commit 63ec55b into main Dec 23, 2022
@picklelo picklelo deleted the nikhil/311list branch December 23, 2022 00:06
ACucos1 pushed a commit to ACucos1/rd-pynecone that referenced this pull request Feb 28, 2023
@picklelo
Fix generic alias checks (reflex-dev#172)
3681783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alek99 Alek99 Alek99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pc run fails with Python 3.11 (but works with previous versions of python)
2 participants
@picklelo @Alek99