Var: __bool__ and __iter__ always raise a TypeError #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help avoid programming mistakes when using Var, any attempt to use a Var in a conditional, or with short circuit operators will now raise a TypeError with the exception message suggesting the use of `rx.cond`, and bitwise operators instead. Attempting to use a Var with a native for loop or list comprehension will also raise a TypeError suggesting the use of `rx.foreach` ---------------- Fix all test cases that were making erroneous Var assertions * must use `.equals()` to actually compare Var instances * must `._decode()` Vars to compare with python values * must use `if x is not None` instead of `if x` where x is a Var
Truthy-ness of a var cannot be determined at compile time!
In `format_array_ref` check for Var explicitly `is not None`
masenf
changed the title
picklelo
approved these changes
Sep 5, 2023
| Raises: | ||
| TypeError: when attempting to bool-ify the Var. | ||
| """ | ||
| raise TypeError( |
There was a problem hiding this comment.
We can also link to the relevant portion of the docs here
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help avoid programming mistakes when using Var, any attempt to use a Var in a conditional, or with short circuit operators will now raise a TypeError with the exception message suggesting the use of
rx.cond, and bitwise operators instead.Attempting to use a Var with a native for loop or list comprehension will also raise a TypeError suggesting the use of
rx.foreachFix all test cases that were making erroneous Var assertions
.equals()to actually compare Var instances._decode()Vars to compare with python valuesif x is not Noneinstead ofif xwhere x is a Var