Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to disable Tailwind #1842

Merged
merged 8 commits into from
Sep 20, 2023
Merged

add option to disable Tailwind #1842

merged 8 commits into from
Sep 20, 2023

Conversation

ElijahAhianyo
Copy link
Contributor

@ElijahAhianyo ElijahAhianyo commented Sep 20, 2023

This PR provides an option to disable the out-of-the-box supported Tailwind. To do that, simply set the tailwind config to None :

rxconfig.py

import reflex as rx

config = ExampleConfig(
    app_name="example",
    tailwind= None
)

fixes #1829

Docs: reflex-dev/reflex-web#205

Copy link
Collaborator

@Lendemor Lendemor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't tailwind=None be enough to disable tailwind rather than add a disable field?

Also I was thinking we should remove the base tailwind from package.json and only install it if tailwind is not None.

Lendemor
Lendemor previously approved these changes Sep 20, 2023
Copy link
Collaborator

@Lendemor Lendemor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

masenf
masenf previously approved these changes Sep 20, 2023
@ElijahAhianyo ElijahAhianyo dismissed stale reviews from masenf and Lendemor via 7e576e2 September 20, 2023 19:15
@picklelo picklelo merged commit d81d544 into main Sep 20, 2023
Alek99 pushed a commit that referenced this pull request Sep 26, 2023
@picklelo picklelo deleted the elijah/tailwind-disable branch October 9, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't have Tailwind defaulty included in reflex app
4 participants