-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code cleanup (split constants into a folder) #1866
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the namespace classes themselves should be TitleCase
like you'd expect for a class. but otherwise the categorization and breakdown looks just right.
Personally I think it's neater to have them in (i.e a |
Reorganize the constants folder to split them into logical module.
(Also make use of SimpleNamespace to group some constants together.)