Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rx.image src not working with state #1915

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Conversation

Lendemor
Copy link
Collaborator

@Lendemor Lendemor commented Oct 4, 2023

Serialization update may have broken the src parameter of rx.image working with State var. (haven't checked if it worked before)

Now work with State var (PIL, absolute link or relative link) or raw values

Closes #1914

@masenf
Copy link
Collaborator

masenf commented Oct 4, 2023

I had these examples working a bit ago, do we know what regressed this functionality? https://github.com/masenf/example-pangea

#1619 (comment)

@Lendemor
Copy link
Collaborator Author

Lendemor commented Oct 4, 2023

I had these examples working a bit ago, do we know what regressed this functionality? https://github.com/masenf/example-pangea

#1619 (comment)

I'm not sure, I didn't dig to find the cause of the regression.
I'm assuming some changes during the serialization changes broke something, need further investigation if we want the exact cause.

@masenf
Copy link
Collaborator

masenf commented Oct 4, 2023

It broke in 0.2.8, was working in 0.2.7; Mainly i just want to know if we have a class of bugs that was introduced in that release or if this is a one off problem.

@masenf
Copy link
Collaborator

masenf commented Oct 4, 2023

Here is the change that introduced this issue: 1938a6c#diff-4652c902f558b2570fb46d70122cd9bcf9045c7235cebb2c49bd10a8054ace1fL63-R65

Looks like our testing is better now, but we're still missing the case where the src comes from a state Var

@picklelo picklelo merged commit 5893327 into main Oct 4, 2023
36 checks passed
@picklelo picklelo deleted the lendemor/fix_rx_image branch October 9, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rx.image src can not load from State variable
3 participants