Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove victory charts #1945

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Remove victory charts #1945

merged 2 commits into from
Oct 24, 2023

Conversation

ElijahAhianyo
Copy link
Collaborator

remove deprecated victory charts

@ElijahAhianyo ElijahAhianyo marked this pull request as ready for review October 11, 2023 13:46
masenf
masenf approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve, but lets hold off on merging this until we're really ready to ship... then if some show stopper bug from 0.2.9 pops up, we can still fix it as 0.2.10;

once this goes to main, we basically have to ship the breaker 0.3.0

@picklelo picklelo merged commit 1662066 into main Oct 24, 2023
36 checks passed
@picklelo picklelo deleted the elijah/remove-victory branch November 1, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElijahAhianyo @masenf @picklelo