-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate get_ methods for router_data, use BaseVars instead #1967
Conversation
My initial gut reaction is, "what if i want my own state vars called To provide any API on the Thoughts? |
I think it's a good point, We could make a
that contains everything. My initial idea was that I didn't want to have something too long to access when rendering. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm realizing that a consequence of this approach is that we're now sending back all of the router data vars over the websocket with any navigation event. Maybe that's okay, it's certainly more convenient if we need to render these values.
I think it's okay yeah. |
New API for accessing router_data.
Deprecate all the previous methods:
get_token
,get_headers
, ....Introduced 3 new
BaseVar
in State:State.headers
,State.session
,State.page
Will fix the units tests soon.