Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: changing type of playing #1986

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Bug: changing type of playing #1986

merged 1 commit into from
Oct 17, 2023

Conversation

Billa05
Copy link
Contributor

@Billa05 Billa05 commented Oct 17, 2023

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

  • Bug fix (non-breaking change which fixes an issue)

changing type of playing from str to bool
closes #1983

masenf
masenf approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@masenf
Copy link
Collaborator

masenf commented Oct 17, 2023

AppHarness tests are failing until #1987 can merge. Will take this PR after that.

@picklelo picklelo merged commit 317b883 into reflex-dev:main Oct 17, 2023
37 checks passed
@picklelo picklelo mentioned this pull request Oct 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audio "playing" flag is the wrong type.
3 participants
@Billa05 @masenf @picklelo