[reflex export] backend.zip excludes dirs that look like venv dirs #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picklelo
approved these changes
Oct 23, 2023
| @@ -59,6 +59,8 @@ def _zip( | |||
| component_name: constants.ComponentName, | |||
| target: str, | |||
| root_dir: str, | |||
| exclude_venv_dirs: bool, | |||
There was a problem hiding this comment.
should we add default values for these args?
There was a problem hiding this comment.
I don't think so. Default values are usually for convenience:
- We cannot (or don't want to) update existing call sites.
- We think it's too burdensome to ask new call sites to be explicit.
But the drawback is we lose (IMO) a lot of readability.
In this case the trade-off seems quite skewed toward not doing defaults. It's a private function that has two existing call sites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We leave
frontend.zipalone, because by design we only zip up generated.web/. Chance of false positive vs. false negative would be higher there (for excluding something that shouldn't).For
backend.zip, we exclude venv looking files (detected by presence ofpyvenv.cfg).As a drive-by we also exclude
*.dbfrombackend.zip.