-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autogenerating Dependencies During Deployment #2033
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alek99
changed the title
Test to see if Autogenerating dependencies During Deployment is viable
Autogenerating Dependencies During Deployment
Oct 25, 2023
martinxu9
reviewed
Oct 25, 2023
console.warn("It seems like there's no requirements.txt in your project.") | ||
response = console.ask( | ||
"Would you like us to auto-generate one based on your current environment?", | ||
choices=["y", "n"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Do we want to give them Y/n, enter is yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather not here just because I want this command to be very explicit
masenf
reviewed
Oct 26, 2023
masenf
previously approved these changes
Oct 26, 2023
masenf
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Approach
Generate a requirements.txt with just reflex. When the user goes to deploy if they do not add any packages to requirements.txt warn them about this and proceed with their deployment.
If they are missing any the deployment will fail when running the backend.
Proposed Approach
If a requirements.txt is not present in the user's project when they go to deploy generate a requirements.txt using only their top-level dependencies.
If the requirements.txt is present skip.
Generates a requirement.txt in the root of their project
Pros
Cons