Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix onload method not working in prod mode (and hosting) #2049

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

Lendemor
Copy link
Collaborator

No description provided.

Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@picklelo picklelo merged commit edf9c32 into main Oct 27, 2023
37 checks passed
@masenf
Copy link
Collaborator

masenf commented Oct 27, 2023

Wow, very good fix... we miss this in testing because test_dynamic_routes doesn't use the page decorator.

@picklelo picklelo deleted the lendemor/fix_onload_prod branch November 1, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants