Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back build log command to CLI #2053

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Conversation

martinxu9
Copy link
Contributor

@martinxu9 martinxu9 commented Oct 27, 2023

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

  • Add back the "build" log command for controller unable to complete the deploy workflow (e.g. something wrong with requirements.txt)
  • Test: change the clock demo app requirements.txt with fake package name. The deploy should fail at docker image build image
  • Then build-logs says: image
  • With a missing requirement, this should look like this (deploy success, but backend stuck in infinite reboot loop)image

@martinxu9 martinxu9 requested a review from picklelo October 27, 2023 16:41
@picklelo picklelo merged commit 23255d4 into main Oct 27, 2023
37 checks passed
@picklelo picklelo deleted the martinxu9/add-back-build-log branch November 1, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants