[REF-1035] Track ComputedVar dependency per class #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to recompute these every time a state is initialized, which can be basically for every request if we're using redis.
…ates Instead of calculating these every time there is a delta, determine them at subclass definition time (or when adding a var dynamically). This should improve performance for every delta calculation. It also fixes #2066 by tracking substates which have ComputedVar with _cache=False Fix REF-1035
masenf
force-pushed
the
masenf/computed-var-tracking
branch
from
af1b042 to
5d5e712
Compare
masenf
changed the title
picklelo
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_always_dirty_computed_varstracking to subclass initialization, again, not needed every time a delta is computed_computed_var_dependenciesand_substate_var_dependenciesto indicate they are privateFix #2066
Additional testing is needed, as we should have had some tests that fail without this change.