Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fixed wrapping react link #2097

Merged
merged 2 commits into from
Oct 31, 2023
Merged

docs: fixed wrapping react link #2097

merged 2 commits into from
Oct 31, 2023

Conversation

Shreyas0410
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Fixes #2096

Fixed the wrapping react link.

Screenshot 2023-10-31 221458

masenf
masenf previously approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@masenf
Copy link
Collaborator

masenf commented Oct 31, 2023

@Shreyas0410 do you mind also making this correction in the translated README?

Lendemor
Lendemor previously approved these changes Oct 31, 2023
View reviewed changes
@Shreyas0410
Copy link
Contributor Author

@masenf ok i will do it.

@Shreyas0410 Shreyas0410 dismissed stale reviews from Lendemor and masenf via be96a76 October 31, 2023 17:22
masenf
masenf approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks so much for the contribution

@masenf masenf merged commit e82bc40 into reflex-dev:main Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf approved these changes

@Lendemor Lendemor Lendemor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken link of wrapping react in readme file
3 participants
@Shreyas0410 @masenf @Lendemor