Separate out the hosting CLI from main repo #2165
Conversation
martinxu9
changed the title
| config = get_config() | ||
|
|
||
|
|
||
| def export( |
There was a problem hiding this comment.
this is the main logic inside the export typer command, rid it out into its own function so it can be passed into the hosting CLI as "callback" to run export.
| # Set the log level. | ||
| console.set_log_level(loglevel) | ||
|
|
||
| # Override the config url values if provided. |
There was a problem hiding this comment.
this is added logic. Since hosting CLI does not have access to config, it can only pass back these for the reflex framework to override its config.
| "Please provide a name for the deployed instance when not in interactive mode." | ||
| ) | ||
| raise typer.Exit(1) | ||
|
|
||
| dependency.check_requirements() |
There was a problem hiding this comment.
these are reordered to run first (they mostly should be anyway), so don't have to pass any functions into the hosting CLI.
|
Seems to be working for me just tried a deployment on the branch |
martinxu9
changed the title
martinxu9
force-pushed
the
martinxu9/separate-cli
branch
from
732d818 to
bd96790
Compare
|
This PR is ready. |
reflex/reflex.py
Outdated
| from reflex.utils import console, dependency, telemetry | ||
| from reflex.utils import ( | ||
| console, | ||
| telemetry, |
There was a problem hiding this comment.
nit: can remove the last comma to fit this on one line
reflex/reflex.py
Outdated
| @@ -103,7 +101,7 @@ def _init( | |||
| prerequisites.initialize_gitignore() | |||
|
|
|||
| # Initialize the requirements.txt. | |||
| prerequisites.initialize_requirements_txt() | |||
| dependency.initialize_requirements_txt() | |||
There was a problem hiding this comment.
Should this be part of this package since it's a bit unrelated to the hosting? The initial one will only have the reflex package in it anyways. If we want to update this it may make it harder
There was a problem hiding this comment.
Synced on discord. The desired code is in here now: https://discord.com/channels/@me/1141437177448906882/1179140841089007700, we'll move that back to reflex repo so open source can see what is actually done when we init.
There was a problem hiding this comment.
updated in the latest rev
All Submissions:
Type of change
Please delete options that are not relevant.
New Feature Submission:
Changes To Core Features:
After these steps, you're ready to open a pull request.
reflex-hosting-clibecomes a dependency ofreflex, and make it>=so it'll be easy to update hosting CLI without needing to upgrade reflex framework.websockets,tabulate.reflex exportcommand implementation by moving the underly function into its own fileutils/export.py. This way the export util can be passed into hosting CLI as callback. Deploy command executesexportin the middle of it. This part is less ideal, the flow of code runs back and forth. Ideally with hosting CLI as dependency, the flow should be from reflex to hosting CLI.