Memoize markdown component_map #2219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 25, 2023
The SyntaxHighlighter component is more reliable when the code itself is passed via prop, rather than passed as an actual child. So save any passed child to the `code` prop. And then render the contents of the `code` prop as `children=` special prop (similar to how the rx.markdown component did it) Using this new mechanism, the SyntaxHighlighter can work with rx.markdown at arbitrary nesting levels (for example, when used with a custom component_map)
Always move the component map to a separate function (and include any hooks, so the components can access state/colorMode). This allows the markdown component itself to not depend on state (and thus be rendered directly in the page) while having its constituent components depend on state.
masenf
force-pushed
the
masenf/markdown-component-map
branch
from
3f7183c to
e379393
Compare
picklelo
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
component_mappassed to the markdown componentrx.condfor code_blockthemepropcode_blockin markdown component_mapAddress #2217 (or at least part of it)