[reflex-web tweaks] Do not memoize children of InputGroup #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Chakra InputGroup component depends on its children being specific types of components, so a memoized Input_* is not "seen" as the input component.
picklelo
reviewed
Nov 29, 2023
reflex/components/component.py
Outdated
| from reflex.components.layout.foreach import Foreach | ||
|
|
||
| # Foreach must be memoized as a single component to retain index Var context. | ||
| if not isinstance(component, Foreach): | ||
| if not isinstance(component, (Foreach, InputGroup)): |
There was a problem hiding this comment.
We should update the comment here too. Do we need to add any other components to this tuple?
There was a problem hiding this comment.
Yeah, maybe the ButtonGroup. I'll poke around
To help handle memoization exceptions and special cases as they are discovered, use a field on Component which controls aspecs of the auto-memoization process. For now, only the "recursive" boolean is understood. There is certain to be future categories of exceptions to memoization that will be discovered, so instead of plumbing additional fields through, the MemoizationMode can be extended with defaults and used to handle these special cases in the components that need them, rather than centrally in the Component or StatefulComponent logic. Replace special case recursive logic for Foreach and InputGroup components with this new mechanism.
picklelo
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Chakra InputGroup component depends on its children being specific types of components, so a memoized Input_* is not "seen" as the input component.