Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF-1425] Always capitalize tag of StatefulComponent #2264

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

masenf
Copy link
Collaborator

@masenf masenf commented Dec 6, 2023

Lowercase tags in JSX are rendered as plain HTML, so the code hash suffix breaks the element.

import reflex as rx


class State(rx.State):
    v: str = "foo"


def index() -> rx.Component:
    return rx.el.div(State.v)


app = rx.App()
app.add_page(index)
app.compile()

should show "foo"

Lowercase tags in JSX are rendered as plain HTML, so the code hash suffix
breaks the element.
@picklelo picklelo merged commit e0a1b39 into main Dec 6, 2023
45 checks passed
@masenf masenf deleted the masenf/stateful-plain-html branch December 6, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants