add event triggers for rx.video #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picklelo
reviewed
Feb 22, 2024
picklelo
previously approved these changes
Feb 23, 2024
|
reflex-web really needs a better method for getting docs of event triggers; right now this is causing chicken-egg failures because reflex-web doesn't know about "on_start", "on_ended", etc |
masenf
reviewed
Feb 29, 2024
| @@ -32,49 +32,52 @@ class Audio(ReactPlayer): | |||
| class_name: Optional[Any] = None, | |||
| autofocus: Optional[bool] = None, | |||
| custom_attrs: Optional[Dict[str, Union[Var, str]]] = None, | |||
| on_blur: Optional[ | |||
| onBuffer: Optional[ | |||
There was a problem hiding this comment.
are these supposed to be camel case? or did they just not get regenerated?
…yer_event_trigger
Allow the PR to pass reflex-web integration test now that inline comments are respected for EventHandler props.
picklelo
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.