Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a reflex logo component #2994

Merged
merged 5 commits into from
Apr 4, 2024
Merged

adding a reflex logo component #2994

merged 5 commits into from
Apr 4, 2024

Conversation

tgberkeley
Copy link
Collaborator

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

b. Describe your changes.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

@tgberkeley tgberkeley requested a review from picklelo April 3, 2024 01:12
rx.link(
rx.hstack(
"Built with ",
rx.image(src="https://raw.githubusercontent.com/reflex-dev/reflex-web/main/assets/Reflex.svg"),
Copy link
Collaborator

@Lendemor Lendemor Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer we add the svg file in the repo rather than using a link.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently don't have a way to bundle up assets with a component (unless we include the logos in every app by default, which we probably don't want)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but using a link means we'll break some version of Reflex in the future if we ever move the image somewhere.
Could we make a NPM package that is a dependency of Logo ?
This way the image would be only installed when the component is used?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put it into html and then inside a color mode cond

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

rx.link(
rx.hstack(
"Built with ",
rx.image(src="https://raw.githubusercontent.com/reflex-dev/reflex-web/main/assets/Reflex.svg"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do rx.color_mode_cond and show the white logo in dark mode: https://github.com/reflex-dev/reflex-web/blob/main/assets/Reflex_white.svg

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

masenf
masenf previously approved these changes Apr 4, 2024
reflex/components/datadisplay/logo.py Outdated Show resolved Hide resolved
Co-authored-by: Masen Furer <m_github@0x26.net>
@picklelo picklelo merged commit 0619017 into main Apr 4, 2024
46 checks passed
@masenf masenf deleted the create-reflex-logo-component branch April 24, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants