-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding a reflex logo component #2994
Conversation
rx.link( | ||
rx.hstack( | ||
"Built with ", | ||
rx.image(src="https://raw.githubusercontent.com/reflex-dev/reflex-web/main/assets/Reflex.svg"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer we add the svg file in the repo rather than using a link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We currently don't have a way to bundle up assets with a component (unless we include the logos in every app by default, which we probably don't want)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but using a link means we'll break some version of Reflex in the future if we ever move the image somewhere.
Could we make a NPM package that is a dependency of Logo ?
This way the image would be only installed when the component is used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put it into html and then inside a color mode cond
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
rx.link( | ||
rx.hstack( | ||
"Built with ", | ||
rx.image(src="https://raw.githubusercontent.com/reflex-dev/reflex-web/main/assets/Reflex.svg"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do rx.color_mode_cond
and show the white logo in dark mode: https://github.com/reflex-dev/reflex-web/blob/main/assets/Reflex_white.svg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Co-authored-by: Masen Furer <m_github@0x26.net>
All Submissions:
Type of change
Please delete options that are not relevant.
New Feature Submission:
Changes To Core Features:
After these steps, you're ready to open a pull request.