Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Pin Bun version #3192

Merged
merged 2 commits into from
May 1, 2024
Merged

Windows Pin Bun version #3192

merged 2 commits into from
May 1, 2024

Conversation

ElijahAhianyo
Copy link
Collaborator

@ElijahAhianyo ElijahAhianyo commented Apr 30, 2024

Bun doesnt allow installing a previous version of bun on windows (this is not the case for mac and linux). However, we still need a bit of control on what versions we can install in case of upstream break or incompatibilities. As a workaround, this PR saves a modified local copy(in scripts directory) of the bun install script for windows which allows installing a specific version when the BUN_VERSION env is set (otherwise it installs the latest version).

@ElijahAhianyo ElijahAhianyo marked this pull request as ready for review April 30, 2024 14:58
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@picklelo picklelo merged commit 93c4f50 into main May 1, 2024
46 checks passed
@picklelo picklelo deleted the elijah/bun-pin-version branch August 21, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants